JS: remove cookie source; rely on persistent flow steps instead#698
Merged
Conversation
ghost
suggested changes
Dec 17, 2018
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM. I am surprised this did not eliminate more FPs.
This technically requires a change to the change note for #629. Lets make a catch-all change:
- Support for popular libraries has been improved. Consequently, queries may produce more results on code bases that use the following features:
->
- Support for popular libraries has been improved. Consequently, queries may produce better results on code bases that use the following features:
ghost
suggested changes
Dec 19, 2018
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Can we use a different source of remote input in the tests instead? The current change effectively disables the tests.
asger-semmle
force-pushed
the
remove-cookie-as-source
branch
from
4b0bb19 to
ce18aca
Compare
Contributor
Author
|
You're right, I was way too quick to just accept the changes as they were. I've force-pushed some udpated tests. PTAL. |
xiemaisi
pushed a commit
to xiemaisi/ql
that referenced
this pull request
Jan 9, 2019
github#698 removed `document.cookie` as a remote flow source, which some of the tests relied on. We now use `location.search` instead.
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Release preparation for version 2.8.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, we should start to treat cookies as persistent storage flow steps (#629) instead of treating client-side cookie access as remote flow.
Evaluation.